Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 977283002: Display call site data for functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/test/debugging_test.dart ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index d8361e0d30c6a32a728b2e98709c4b15759a5d02..fe7c5ea4f858c7b1550369164774aec7385459b8 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -112,7 +112,7 @@ TEST_CASE(StacktraceInfo) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(2, line_number);
- EXPECT_EQ(13, column_number);
+ EXPECT_EQ(10, column_number);
result = Dart_GetActivationFrame(stacktrace, 2, &frame);
EXPECT_VALID(result);
@@ -124,7 +124,7 @@ TEST_CASE(StacktraceInfo) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(3, line_number);
- EXPECT_EQ(18, column_number);
+ EXPECT_EQ(15, column_number);
// Out-of-bounds frames.
result = Dart_GetActivationFrame(stacktrace, frame_count, &frame);
@@ -190,7 +190,7 @@ TEST_CASE(DeepStacktraceInfo) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(1, line_number);
- EXPECT_EQ(43, column_number);
+ EXPECT_EQ(40, column_number);
}
// Bottom frame positioned at testMain().
@@ -204,7 +204,7 @@ TEST_CASE(DeepStacktraceInfo) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(2, line_number);
- EXPECT_EQ(18, column_number);
+ EXPECT_EQ(15, column_number);
// Out-of-bounds frames.
result = Dart_GetActivationFrame(stacktrace, frame_count, &frame);
@@ -327,7 +327,7 @@ void CurrentStackTraceNative(Dart_NativeArguments args) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(2, line_number);
- EXPECT_EQ(32, column_number);
+ EXPECT_EQ(20, column_number);
// Middle frames positioned at the recursive call.
for (intptr_t frame_index = 2;
@@ -343,7 +343,7 @@ void CurrentStackTraceNative(Dart_NativeArguments args) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(2, line_number);
- EXPECT_EQ(40, column_number);
+ EXPECT_EQ(37, column_number);
}
// Bottom frame positioned at testMain().
@@ -357,7 +357,7 @@ void CurrentStackTraceNative(Dart_NativeArguments args) {
Dart_StringToCString(script_url, &cstr);
EXPECT_STREQ("test-lib", cstr);
EXPECT_EQ(3, line_number);
- EXPECT_EQ(18, column_number);
+ EXPECT_EQ(15, column_number);
// Out-of-bounds frames.
result = Dart_GetActivationFrame(stacktrace, frame_count, &frame);
« no previous file with comments | « runtime/observatory/test/debugging_test.dart ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698