Issue 977223003: When target requires a function, propose a function reference, not an invocation

Issue 977223003: When target requires a function, propose a function reference, not an invocation (Closed)

Created:
5 years, 9 months ago by danrubel

Modified:
5 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

When target requires a function, propose a function reference, not an invocation BUG=dartbug.com/22360 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44271

Patch Set 2 : merge and update editor to process IDENTIFIER suggestions #

Total comments: 2

Patch Set 3 : merge and remove unnecessary statement #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+504 lines, -136 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/completion_target.dart	View	1 2	4 chunks	+86 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/imported_computer.dart	View		3 chunks	+22 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/local_computer.dart	View		1 chunk	+13 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/combinator_computer_test.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_target_test.dart	View		2 chunks	+88 lines, -26 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_test_util.dart	View		13 chunks	+209 lines, -69 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/imported_computer_test.dart	View		3 chunks	+47 lines, -23 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/local_computer_test.dart	View		2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

lgtm https://codereview.chromium.org/977223003/diff/20001/pkg/analysis_server/lib/src/services/completion/completion_target.dart File pkg/analysis_server/lib/src/services/completion/completion_target.dart (right): https://codereview.chromium.org/977223003/diff/20001/pkg/analysis_server/lib/src/services/completion/completion_target.dart#newcode210 pkg/analysis_server/lib/src/services/completion/completion_target.dart:210: parent.constructorName; Remove this?

5 years, 9 months ago (2015-03-05 20:51:10 UTC) #3

danrubel

https://codereview.chromium.org/977223003/diff/20001/pkg/analysis_server/lib/src/services/completion/completion_target.dart File pkg/analysis_server/lib/src/services/completion/completion_target.dart (right): https://codereview.chromium.org/977223003/diff/20001/pkg/analysis_server/lib/src/services/completion/completion_target.dart#newcode210 pkg/analysis_server/lib/src/services/completion/completion_target.dart:210: parent.constructorName; On 2015/03/05 20:51:09, scheglov wrote: > Remove this? ...

5 years, 9 months ago (2015-03-05 21:23:40 UTC) #4

danrubel

5 years, 9 months ago (2015-03-05 21:26:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 44271 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages