pkg/analysis_server/test/services/completion/combinator_computer_test.dart - Issue 977223003: When target requires a function, propose a function reference, not an invocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/combinator_computer_test.dart

Issue 977223003: When target requires a function, propose a function reference, not an invocation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge and remove unnecessary statement Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | pkg/analysis_server/test/services/completion/completion_target_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/combinator_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/combinator_computer_test.dart b/pkg/analysis_server/test/services/completion/combinator_computer_test.dart

index 8e70f1ce0dc46ecd8f5fee66a586f44bbf2a73fd..d924f815b36515216a65fb5642502720a725f228 100644

--- a/pkg/analysis_server/test/services/completion/combinator_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/combinator_computer_test.dart

@@ -70,8 +70,8 @@ class CombinatorComputerTest extends AbstractCompletionTest {

kind: CompletionSuggestionKind.IDENTIFIER);

assertSuggestTopLevelVar('T1', null,

DART_RELEVANCE_DEFAULT, CompletionSuggestionKind.IDENTIFIER);

- assertSuggestFunction('F1', 'PB', false,

- DART_RELEVANCE_DEFAULT, CompletionSuggestionKind.IDENTIFIER);

+ assertSuggestFunction('F1', 'PB',

+ kind: CompletionSuggestionKind.IDENTIFIER);

assertNotSuggested('C');

assertNotSuggested('D');

assertNotSuggested('X');

@@ -113,8 +113,8 @@ class CombinatorComputerTest extends AbstractCompletionTest {

kind: CompletionSuggestionKind.IDENTIFIER);

assertSuggestTopLevelVar('T1', null,

DART_RELEVANCE_DEFAULT, CompletionSuggestionKind.IDENTIFIER);

- assertSuggestFunction('F1', 'PB', false,

- DART_RELEVANCE_DEFAULT, CompletionSuggestionKind.IDENTIFIER);

+ assertSuggestFunction('F1', 'PB',

+ kind: CompletionSuggestionKind.IDENTIFIER);

assertSuggestClass('Clz',

relevance: DART_RELEVANCE_DEFAULT,

kind: CompletionSuggestionKind.IDENTIFIER);