Issue 975753002: Some clean-ups for Index / SearchEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 975753002: Some clean-ups for Index / SearchEngine. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Some clean-ups for Index / SearchEngine. 1. Remove the TODO, it is better to keep searchTopLevelDeclarations() returning Future, for consistency and possible future changes. 2. Rename IndexStore.recordTopDeclaration() to recordTopLevelDeclaration(). Sorry, I missed it initially. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44182

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -21 lines)			Patch
M	pkg/analysis_server/lib/src/services/index/index_contributor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_store.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/split_store.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/search/search_engine_internal.dart	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/dart_index_contributor_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/store/split_store_test.dart	View	5 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 9 months ago (2015-03-03 16:55:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44182 (presubmit successful).

Expand Messages | Collapse Messages