Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: pkg/analysis_server/lib/src/services/search/search_engine_internal.dart

Issue 975753002: Some clean-ups for Index / SearchEngine. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart b/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
index 9fc3141b9e679103d5f6298ebda39ca149b71c61..e5c80dddc59cd055c10e74270044e6fa8e3a8005 100644
--- a/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
+++ b/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
@@ -10,6 +10,7 @@ import 'package:analysis_server/src/services/index/index.dart';
import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/generated/source.dart';
+import 'package:analysis_server/src/services/correction/source_range.dart';
/**
* A [SearchEngine] implementation.
@@ -102,13 +103,10 @@ class SearchEngineImpl implements SearchEngine {
List<Element> elements =
_index.getTopLevelDeclarations((String name) => regExp.hasMatch(name));
List<SearchMatch> matches = <SearchMatch>[];
- for (var element in elements) {
- SourceRange range =
- new SourceRange(element.nameOffset, element.name.length);
- matches.add(
- new SearchMatch(MatchKind.DECLARATION, element, range, true, false));
+ for (Element element in elements) {
+ matches.add(new SearchMatch(MatchKind.DECLARATION, element,
+ rangeElementName(element), true, false));
}
- // TODO(scheglov) it does not have to be a Future
return new Future.value(matches);
}

Powered by Google App Engine
This is Rietveld 408576698