Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 974953002: Revert "Fix issues with Socket shutdown." (Closed)

Created:
5 years, 9 months ago by Bill Hesse
Modified:
5 years, 9 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix issues with Socket shutdown." This reverts commit r44178, because it makes 10 tests about process stderr and stdin fail with timeouts. Original CL: https://codereview.chromium.org/975723002/ BUG=dartbug.com/22637 BUG=dartbug.com/22636 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=44180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -73 lines) Patch
M runtime/bin/socket_patch.dart View 4 chunks +2 lines, -5 lines 0 comments Download
D tests/standalone/io/issue_22637_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 9 months ago (2015-03-03 16:41:40 UTC) #2
kustermann
LGTM
5 years, 9 months ago (2015-03-03 16:51:35 UTC) #3
Bill Hesse
5 years, 9 months ago (2015-03-03 16:52:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698