Issue 971833003: Optimize top-level element declarations search.

Issue 971833003: Optimize top-level element declarations search. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Optimize top-level element declarations search. No limits on the number of returned matches yet. With this CL it takes about 20 ms for one-character regexp, vs. 200+ ms before. The Editor UI is still not quite fast, we need to set some limits there too. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44145

Patch Set 1 #

Total comments: 4

Patch Set 2 : Tweaks for review comments #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -308 lines)			Patch
M	pkg/analysis_server/lib/src/services/index/index.dart	View	1	3 chunks	+11 lines, -17 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_contributor.dart	View		8 chunks	+15 lines, -16 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_store.dart	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/local_index.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/split_store.dart	View	1	12 chunks	+67 lines, -70 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/search/search_engine_internal.dart	View	1	1 chunk	+8 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/dart_index_contributor_test.dart	View		9 chunks	+15 lines, -25 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/local_index_test.dart	View	1	5 chunks	+29 lines, -51 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/store/split_store_test.dart	View	1	2 chunks	+77 lines, -119 lines	0 comments	Download
M	pkg/analysis_server/test/services/search/search_engine_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM! https://codereview.chromium.org/971833003/diff/1/pkg/analysis_server/lib/src/services/index/index_store.dart File pkg/analysis_server/lib/src/services/index/index_store.dart (right): https://codereview.chromium.org/971833003/diff/1/pkg/analysis_server/lib/src/services/index/index_store.dart#newcode89 pkg/analysis_server/lib/src/services/index/index_store.dart:89: List<Element> getTopDeclarations(ElementNameFilter nameFilter); "Top" --> "TopLevel"? I know ...

5 years, 9 months ago (2015-03-02 19:20:08 UTC) #2

scheglov

https://codereview.chromium.org/971833003/diff/1/pkg/analysis_server/lib/src/services/index/index_store.dart File pkg/analysis_server/lib/src/services/index/index_store.dart (right): https://codereview.chromium.org/971833003/diff/1/pkg/analysis_server/lib/src/services/index/index_store.dart#newcode89 pkg/analysis_server/lib/src/services/index/index_store.dart:89: List<Element> getTopDeclarations(ElementNameFilter nameFilter); On 2015/03/02 19:20:07, Brian Wilkerson wrote: ...

5 years, 9 months ago (2015-03-02 19:55:47 UTC) #3

scheglov

5 years, 9 months ago (2015-03-02 19:56:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44145 (presubmit successful).

Expand Messages | Collapse Messages