Optimize top-level element declarations search.

pkg/analysis_server/test/services/index/local_index_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.src.index.local_index;
 
-import 'dart:async';
-
-import 'package:analysis_server/src/services/index/index.dart';
 import 'package:analysis_server/src/services/index/local_index.dart';
 import 'package:analysis_server/src/services/index/local_memory_index.dart';
 import 'package:analyzer/src/generated/ast.dart';
+import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/html.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../abstract_context.dart';
 import '../../reflective_tests.dart';
 import 'store/single_source_container.dart';
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(LocalIndexTest);
 }
 
 
-void _assertElementNames(List<Location> locations, List expected) {
-  expect(_toElementNames(locations), unorderedEquals(expected));
+void _assertElementNames(List<Element> elements, List expected) {
+  expect(_toElementNames(elements), unorderedEquals(expected));
 }
 
 
-Iterable<String> _toElementNames(List<Location> locations) {
-  return locations.map((loc) => loc.element.name);
+Iterable<String> _toElementNames(List<Element> elements) {
+  return elements.map((element) => element.name);
 }
 
 
 @reflectiveTest
 class LocalIndexTest extends AbstractContextTest {
   LocalIndex index;
 
   void setUp() {
     super.setUp();
     index = createLocalMemoryIndex();
   }
 
   void tearDown() {
     super.tearDown();
     index = null;
   }
 
-  Future test_clear() {
+  void test_clear() {
     _indexTest('main() {}');
-    return _getDefinedFunctions().then((locations) {
-      _assertElementNames(locations, ['main']);
+    _assertElementNames(_getTopElements(), ['main']);
       // clear
-      index.clear();
-      return _getDefinedFunctions().then((locations) {
-        expect(locations, isEmpty);
-      });
-    });
+    index.clear();
+    expect(_getTopElements(), isEmpty);
   }
 
   void test_indexHtmlUnit_nullUnit() {
     index.indexHtmlUnit(context, null);
   }
 
   void test_indexHtmlUnit_nullUnitElement() {
     HtmlUnit unit = new HtmlUnit(null, [], null);
     index.indexHtmlUnit(context, unit);
   }
 
-  Future test_indexUnit() {
+  void test_indexUnit() {
     _indexTest('main() {}');
-    return _getDefinedFunctions().then((locations) {
-      _assertElementNames(locations, ['main']);
-    });
+    _assertElementNames(_getTopElements(), ['main']);
   }
 
   void test_indexUnit_nullUnit() {
     index.indexUnit(context, null);
   }
 
   void test_indexUnit_nullUnitElement() {
     CompilationUnit unit = new CompilationUnit(null, null, [], [], null);
     index.indexUnit(context, unit);
   }
 
-  Future test_removeContext() {
+  void test_removeContext() {
     _indexTest('main() {}');
-    return _getDefinedFunctions().then((locations) {
-      // OK, there is a location
-      _assertElementNames(locations, ['main']);
-      // remove context
-      index.removeContext(context);
-      return _getDefinedFunctions().then((locations) {
-        expect(locations, isEmpty);
-      });
-    });
+    // OK, there is an element
+    _assertElementNames(_getTopElements(), ['main']);
+    // remove context
+    index.removeContext(context);
+    expect(_getTopElements(), isEmpty);
   }
 
-  Future test_removeSource() {
+  void test_removeSource() {
     Source sourceA = _indexLibraryUnit('/testA.dart', 'fa() {}');
     _indexLibraryUnit('/testB.dart', 'fb() {}');
-    return _getDefinedFunctions().then((locations) {
       // OK, there are 2 functions
-      _assertElementNames(locations, ['fa', 'fb']);
-      // remove source
-      index.removeSource(context, sourceA);
-      return _getDefinedFunctions().then((locations) {
-        _assertElementNames(locations, ['fb']);
-      });
-    });
+    _assertElementNames(_getTopElements(), ['fa', 'fb']);
+    // remove source
+    index.removeSource(context, sourceA);
+    _assertElementNames(_getTopElements(), ['fb']);
   }
 
-  Future test_removeSources() {
+  void test_removeSources() {
     Source sourceA = _indexLibraryUnit('/testA.dart', 'fa() {}');
     _indexLibraryUnit('/testB.dart', 'fb() {}');
-    return _getDefinedFunctions().then((locations) {
-      // OK, there are 2 functions
-      _assertElementNames(locations, ['fa', 'fb']);
+    // OK, there are 2 functions
+    _assertElementNames(_getTopElements(), ['fa', 'fb']);
       // remove source(s)
-      index.removeSources(context, new SingleSourceContainer(sourceA));
-      return _getDefinedFunctions().then((locations) {
-        _assertElementNames(locations, ['fb']);
-      });
-    });
+    index.removeSources(context, new SingleSourceContainer(sourceA));
+    _assertElementNames(_getTopElements(), ['fb']);
   }
 
   void test_statistics() {
     expect(index.statistics, '[0 locations, 0 sources, 0 names]');
   }
 
-  Future<List<Location>> _getDefinedFunctions() {
-    return index.getRelationships(
-        UniverseElement.INSTANCE,
-        IndexConstants.DEFINES);
+  List<Element> _getTopElements() {
+    return index.getTopLevelDeclarations((_) => true);
   }
 
   Source _indexLibraryUnit(String path, String content) {
     Source source = addSource(path, content);
     CompilationUnit dartUnit = resolveLibraryUnit(source);
     index.indexUnit(context, dartUnit);
     return source;
   }
 
   void _indexTest(String content) {
     _indexLibraryUnit('/test.dart', content);
   }
 }