Issue 970063002: When a closure is extracted as a method, it does not have any return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 970063002: When a closure is extracted as a method, it does not have any return type. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

When a closure is extracted as a method, it does not have any return type. But it should not be returned as 'void'. It should be an empty string, as any other method with unknown return type. I guess we could improve this in the future, e.g. promote type of a returned expression into the signature. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44177

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -4 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodFeedback.java	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_method.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_method_test.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 9 months ago (2015-03-03 16:17:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44177 (presubmit successful).

Expand Messages | Collapse Messages