pkg/analysis_server/lib/src/services/refactoring/extract_method.dart - Issue 970063002: When a closure is extracted as a method, it does not have any return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

Issue 970063002: When a closure is extracted as a method, it does not have any return type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/generated_protocol.dart ('k') | pkg/analysis_server/test/services/refactoring/extract_method_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

index 361d537c14e27bc73630659971c4b66f02ba8b7d..d40545c4927cf61c588c68455119cc9825150e2a 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

@@ -615,7 +615,9 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl

}

void _initializeReturnType() {

- if (_returnType == null) {

+ if (_selectionFunctionExpression != null) {

+ returnType = '';

+ } else if (_returnType == null) {

returnType = 'void';

} else {

returnType = _getTypeCode(_returnType);