Avoid unnecessary parsing/resolution when running command line analyzer.

Avoid unnecessary parsing/resolution when running command line analyzer.

By default, the command-line analyzer doesn't show errors, warnings,
or hints for the SDK or for files imported via "package:" URI's.
Accordingly, it shouldn't be necessary to parse or resolve function
bodies in those files.

This can save a substantial amount of time when analyzing files that
are part of large applications.  For example, analysis time of
pkg/analyzer/bin/anaylzer.dart goes down from ~6.5 seconds to ~3.5
seconds.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44143

[Paul Berry, 2015-02-27 23:01:01]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-02-27 23:52:06]

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/analyze...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/analyze...
pkg/analyzer/lib/src/analyzer_impl.dart:267: return true;
This will need to be extended to account for the custom URI map option (sorry
for being vague; I can't remember the command-line flag).

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:6641: AnalyzeFunctionBodiesPredicate
analyzeFunctionBodiesPredicate =
For safety, we should have a setter that replaces null with this default value.

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/parser.dart:15: AnalyzeFunctionBodiesPredicate;
Other than the change to this import and some sorting, I can't see what else
changed (if anything). In particular, I don't see any reference to
'AnalyzeFunctionBodiesPredicate'. What changed?

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/engine_test.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/engine_test.dart:2336:
expect(options.analyzeFunctionBodies, same(value));
What's the value of wrapping the value?

[scheglov, 2015-02-28 02:47:32]

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:2996: body is EmptyFunctionBody &&
!body.semicolon.isSynthetic && node.externalKeyword == null;
Looks like a duplicate code. Fix https://codereview.chromium.org/960093004

[Paul Berry, 2015-03-02 19:09:46]

PTAL

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/analyze...
File pkg/analyzer/lib/src/analyzer_impl.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/analyze...
pkg/analyzer/lib/src/analyzer_impl.dart:267: return true;
On 2015/02/27 23:52:05, Brian Wilkerson wrote:
> This will need to be extended to account for the custom URI map option (sorry
> for being vague; I can't remember the command-line flag).

Ok, I've added a TODO.

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:6641: AnalyzeFunctionBodiesPredicate
analyzeFunctionBodiesPredicate =
On 2015/02/27 23:52:05, Brian Wilkerson wrote:
> For safety, we should have a setter that replaces null with this default
value.

I don't think there's any benefit in auto-converting null to this default value,
since if that's what the client wants they are better off using the
analyzeFunctionBodies setter.  However, I've added a setter that throws an
ArgumentError in the event that the client passes null.  Does that seem
reasonable to you?

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/parser.dart:15: AnalyzeFunctionBodiesPredicate;
On 2015/02/27 23:52:05, Brian Wilkerson wrote:
> Other than the change to this import and some sorting, I can't see what else
> changed (if anything). In particular, I don't see any reference to
> 'AnalyzeFunctionBodiesPredicate'. What changed?

My apologies--this was a mistake.  I'll upload a new version of the CL that
leaves this file unchanged.

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:2996: body is EmptyFunctionBody &&
!body.semicolon.isSynthetic && node.externalKeyword == null;
On 2015/02/28 02:47:31, scheglov wrote:
> Looks like a duplicate code. Fix https://codereview.chromium.org/960093004

Thanks.

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/engine_test.dart (right):

https://codereview.chromium.org/967703002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/engine_test.dart:2336:
expect(options.analyzeFunctionBodies, same(value));
On 2015/02/27 23:52:05, Brian Wilkerson wrote:
> What's the value of wrapping the value?

Sorry--this was left over from a previous experimental version of the CL. 
Reverted.

[Brian Wilkerson, 2015-03-02 19:27:37]

LGTM

[Paul Berry, 2015-03-02 19:38:55]

Committed patchset #2 (id:20001) manually as 44143 (presubmit successful).