Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 963753002: dart2Js: bailout early when using the new emitter with mirrors. (Closed)

Created:
5 years, 9 months ago by zarah
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2Js: bailout early when using the new emitter with mirrors. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44160

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zarah
5 years, 9 months ago (2015-02-27 13:11:18 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/963753002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/963753002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1224 pkg/compiler/lib/src/compiler.dart:1224: internalError(library, This should not be an internal error, ...
5 years, 9 months ago (2015-02-27 14:05:51 UTC) #3
zarah
https://codereview.chromium.org/963753002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/963753002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1224 pkg/compiler/lib/src/compiler.dart:1224: internalError(library, On 2015/02/27 14:05:50, floitsch wrote: > This should ...
5 years, 9 months ago (2015-03-02 10:42:37 UTC) #4
zarah
5 years, 9 months ago (2015-03-03 08:59:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698