Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: pkg/compiler/lib/src/compiler.dart

Issue 963753002: dart2Js: bailout early when using the new emitter with mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/compiler/lib/src/warnings.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * If true, print a warning for each method that was resolved, but not 8 * If true, print a warning for each method that was resolved, but not
9 * compiled. 9 * compiled.
10 */ 10 */
(...skipping 1304 matching lines...) Expand 10 before | Expand all | Expand 10 after
1315 } 1315 }
1316 1316
1317 chainCount++; 1317 chainCount++;
1318 if (chainCount > chainLimit) { 1318 if (chainCount > chainLimit) {
1319 // Assume there are more import chains. 1319 // Assume there are more import chains.
1320 importChains.add('...'); 1320 importChains.add('...');
1321 return false; 1321 return false;
1322 } 1322 }
1323 return true; 1323 return true;
1324 }); 1324 });
1325 reportWarning(NO_LOCATION_SPANNABLE, 1325
1326 MessageKind.IMPORT_EXPERIMENTAL_MIRRORS, 1326 if (const bool.fromEnvironment("dart2js.use.new.emitter")) {
1327 {'importChain': importChains.join( 1327 reportError(NO_LOCATION_SPANNABLE,
1328 MessageKind.IMPORT_EXPERIMENTAL_MIRRORS_PADDING)}); 1328 MessageKind.MIRRORS_LIBRARY_NEW_EMITTER);
1329 } else {
1330 reportWarning(NO_LOCATION_SPANNABLE,
1331 MessageKind.IMPORT_EXPERIMENTAL_MIRRORS,
1332 {'importChain': importChains.join(
1333 MessageKind.IMPORT_EXPERIMENTAL_MIRRORS_PADDING)});
1334 }
1329 } 1335 }
1330 1336
1331 functionClass.ensureResolved(this); 1337 functionClass.ensureResolved(this);
1332 functionApplyMethod = functionClass.lookupLocalMember('apply'); 1338 functionApplyMethod = functionClass.lookupLocalMember('apply');
1333 1339
1334 proxyConstant = 1340 proxyConstant =
1335 resolver.constantCompiler.compileConstant( 1341 resolver.constantCompiler.compileConstant(
1336 coreLibrary.find('proxy')).value; 1342 coreLibrary.find('proxy')).value;
1337 1343
1338 if (preserveComments) { 1344 if (preserveComments) {
(...skipping 1069 matching lines...) Expand 10 before | Expand all | Expand 10 after
2408 return futureClass.computeType(compiler).createInstantiation([elementType]); 2414 return futureClass.computeType(compiler).createInstantiation([elementType]);
2409 } 2415 }
2410 2416
2411 @override 2417 @override
2412 InterfaceType streamType([DartType elementType = const DynamicType()]) { 2418 InterfaceType streamType([DartType elementType = const DynamicType()]) {
2413 return streamClass.computeType(compiler).createInstantiation([elementType]); 2419 return streamClass.computeType(compiler).createInstantiation([elementType]);
2414 } 2420 }
2415 } 2421 }
2416 2422
2417 typedef void InternalErrorFunction(Spannable location, String message); 2423 typedef void InternalErrorFunction(Spannable location, String message);
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/warnings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698