Add a class to start and stop a Chrome process.

Add a class to start and stop a Chrome process.

See #5

R=rnystrom@google.com

Committed: https://github.com/dart-lang/unittest/commit/c45a20164bbcd55e4bafd9b1b56fdba04dedf2ac

[nweiz, 2015-02-27 21:05:34]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-02-27 21:51:41]

https://codereview.chromium.org/958423002/diff/1/lib/src/util/io.dart
File lib/src/util/io.dart (right):

https://codereview.chromium.org/958423002/diff/1/lib/src/util/io.dart#newcode61
lib/src/util/io.dart:61: if (address.isLoopback) {
What if it's an IPv6 loopback?

https://codereview.chromium.org/958423002/diff/1/test/browser/chrome_test.dart
File test/browser/chrome_test.dart (right):

https://codereview.chromium.org/958423002/diff/1/test/browser/chrome_test.dar...
test/browser/chrome_test.dart:28: .add((request) {
The nesting gets pretty deep below here. How about making this function a
top-level one?

[nweiz, 2015-02-28 00:41:55]

Code review changes

[nweiz, 2015-02-28 00:42:05]

https://codereview.chromium.org/958423002/diff/1/lib/src/util/io.dart
File lib/src/util/io.dart (right):

https://codereview.chromium.org/958423002/diff/1/lib/src/util/io.dart#newcode61
lib/src/util/io.dart:61: if (address.isLoopback) {
On 2015/02/27 21:51:40, Bob Nystrom wrote:
> What if it's an IPv6 loopback?

"localhost" is still valid.

https://codereview.chromium.org/958423002/diff/1/test/browser/chrome_test.dart
File test/browser/chrome_test.dart (right):

https://codereview.chromium.org/958423002/diff/1/test/browser/chrome_test.dar...
test/browser/chrome_test.dart:28: .add((request) {
On 2015/02/27 21:51:40, Bob Nystrom wrote:
> The nesting gets pretty deep below here. How about making this function a
> top-level one?

It's only one level of nesting deeper than the base of [setUp], but sure.

[Bob Nystrom, 2015-02-28 01:02:44]

lgtm

https://codereview.chromium.org/958423002/diff/20001/test/browser/chrome_test...
File test/browser/chrome_test.dart (right):

https://codereview.chromium.org/958423002/diff/20001/test/browser/chrome_test...
test/browser/chrome_test.dart:20: var servePage = (request) {
servePage(request) { ...

Does this close over anything, or could you move it outside of main() entirely?

[nweiz, 2015-03-02 22:31:18]

https://codereview.chromium.org/958423002/diff/20001/test/browser/chrome_test...
File test/browser/chrome_test.dart (right):

https://codereview.chromium.org/958423002/diff/20001/test/browser/chrome_test...
test/browser/chrome_test.dart:20: var servePage = (request) {
On 2015/02/28 01:02:44, Bob Nystrom wrote:
> servePage(request) { ...
> 
> Does this close over anything, or could you move it outside of main()
entirely?

It closes over [javaScript].

[nweiz, 2015-03-02 22:35:07]

Committed patchset #2 (id:20001) manually as
c45a20164bbcd55e4bafd9b1b56fdba04dedf2ac (presubmit successful).