Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: lib/src/runner/browser/chrome.dart

Issue 958423002: Add a class to start and stop a Chrome process. (Closed) Base URL: git@github.com:dart-lang/unittest@master
Patch Set: Code review changes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/util/io.dart » ('j') | test/browser/chrome_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/chrome.dart
diff --git a/lib/src/runner/browser/chrome.dart b/lib/src/runner/browser/chrome.dart
new file mode 100644
index 0000000000000000000000000000000000000000..2a198a15fc669925a1603f4478b86ff1f4aa4c7c
--- /dev/null
+++ b/lib/src/runner/browser/chrome.dart
@@ -0,0 +1,88 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library unittest.runner.browser.chrome;
+
+import 'dart:async';
+import 'dart:io';
+
+import '../../util/io.dart';
+
+// TODO(nweiz): move this into its own package?
+// TODO(nweiz): support other browsers.
+/// A class for running an instance of Chrome.
+///
+/// Most of the communication with the browser is expected to happen via HTTP,
+/// so this exposes a bare-bones API. The browser starts as soon as the class is
+/// constructed, and is killed when [close] is called.
+///
+/// Any errors starting or running the process are reported through [onExit].
+class Chrome {
+ /// The underlying process.
+ Process _process;
+
+ /// The temporary directory used as the browser's user data dir.
+ ///
+ /// A new data dir is created for each run to ensure that they're
+ /// well-isolated.
+ String _dir;
+
+ /// A future that completes when the browser exits.
+ ///
+ /// If there's a problem starting or running the browser, this will complete
+ /// with an error.
+ Future get onExit => _onExitCompleter.future;
+ final _onExitCompleter = new Completer();
+
+ /// A future that completes when the browser process has started.
+ ///
+ /// This is used to ensure that [close] works regardless of when it's called.
+ Future get _onProcessStarted => _onProcessStartedCompleter.future;
+ final _onProcessStartedCompleter = new Completer();
+
+ /// Starts a new instance of Chrome open to the given [url], which may be a
+ /// [Uri] or a [String].
+ ///
+ /// If [executable] is passed, it's used as the Chrome executable. Otherwise
+ /// `"google-chrome"` will be looked up on the system PATH.
+ Chrome(url, {String executable}) {
+ if (executable == null) executable = "google-chrome";
+
+ // Don't return a Future here because there's no need for the caller to wait
+ // for the process to actually start. They should just wait for the HTTP
+ // request instead.
+ withTempDir((dir) {
+ _dir = dir;
+ return Process.start(executable, [
+ "--user-data-dir=$_dir",
+ url.toString(),
+ "--disable-extensions",
+ "--disable-popup-blocking",
+ "--bwsi",
+ "--no-first-run"
+ ]).then((process) {
+ _process = process;
+ _onProcessStartedCompleter.complete();
+
+ // TODO(nweiz): the browser's standard output is almost always useless
+ // noise, but we should allow the user to opt in to seeing it.
+ return _process.exitCode;
+ });
+ }).then((exitCode) {
+ if (exitCode != 0) throw "Chrome failed with exit code $exitCode.";
+ }).then(_onExitCompleter.complete)
+ .catchError(_onExitCompleter.completeError);
+ }
+
+ /// Kills the browser process.
+ ///
+ /// Returns the same [Future] as [onExit], except that it won't emit
+ /// exceptions.
+ Future close() {
+ _onProcessStarted.then((_) => _process.kill());
+
+ // Swallow exceptions. The user should explicitly use [onExit] for these.
+ return onExit.catchError((_) {});
+ }
+}
« no previous file with comments | « no previous file | lib/src/util/io.dart » ('j') | test/browser/chrome_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698