- Add a _fatal helper function into dart:core, so that we can

- Add a _fatal helper function into dart:core, so that we can
  abort if we get into an unrecoverable state in the core library.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44010

[Ivan Posva, 2015-02-24 22:01:08]

iposva@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-02-24 22:19:22]

LGTM. Thank you!

https://codereview.chromium.org/953973003/diff/1/runtime/lib/stacktrace.cc
File runtime/lib/stacktrace.cc (left):

https://codereview.chromium.org/953973003/diff/1/runtime/lib/stacktrace.cc#ol...
runtime/lib/stacktrace.cc:48: OS::PrintErr("=== Current Trace:\n%s\n===\n",
stacktrace.ToCString());
Why are you removing the newline after the last stacktrace line? Does the
stacktrace object end with a newline?

[Ivan Posva, 2015-02-24 23:27:18]

Thanks! -ip

https://codereview.chromium.org/953973003/diff/1/runtime/lib/stacktrace.cc
File runtime/lib/stacktrace.cc (left):

https://codereview.chromium.org/953973003/diff/1/runtime/lib/stacktrace.cc#ol...
runtime/lib/stacktrace.cc:48: OS::PrintErr("=== Current Trace:\n%s\n===\n",
stacktrace.ToCString());
On 2015/02/24 22:19:21, hausner wrote:
> Why are you removing the newline after the last stacktrace line? Does the
> stacktrace object end with a newline?

Yes, ends with a newline and then the output looked weird.

[Ivan Posva, 2015-02-24 23:28:03]

Committed patchset #1 (id:1) manually as r44010 (presubmit successful).