runtime/lib/stacktrace.cc - Issue 953973003: - Add a _fatal helper function into dart:core, so that we can

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/stacktrace.cc

Issue 953973003: - Add a _fatal helper function into dart:core, so that we can (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/bootstrap_natives.h"	5 #include "vm/bootstrap_natives.h"

6 #include "vm/exceptions.h"	6 #include "vm/exceptions.h"

7 #include "vm/object_store.h"	7 #include "vm/object_store.h"

8 #include "vm/runtime_entry.h"	8 #include "vm/runtime_entry.h"

9 #include "vm/stack_frame.h"	9 #include "vm/stack_frame.h"

10	10

(...skipping 27 matching lines...) Expand all Loading...
38 const GrowableObjectArray& code_list =	38 const GrowableObjectArray& code_list =

39 GrowableObjectArray::Handle(GrowableObjectArray::New());	39 GrowableObjectArray::Handle(GrowableObjectArray::New());

40 const GrowableObjectArray& pc_offset_list =	40 const GrowableObjectArray& pc_offset_list =

41 GrowableObjectArray::Handle(GrowableObjectArray::New());	41 GrowableObjectArray::Handle(GrowableObjectArray::New());

42 IterateFrames(code_list, pc_offset_list);	42 IterateFrames(code_list, pc_offset_list);

43 const Array& code_array = Array::Handle(Array::MakeArray(code_list));	43 const Array& code_array = Array::Handle(Array::MakeArray(code_list));

44 const Array& pc_offset_array =	44 const Array& pc_offset_array =

45 Array::Handle(Array::MakeArray(pc_offset_list));	45 Array::Handle(Array::MakeArray(pc_offset_list));

46 const Stacktrace& stacktrace = Stacktrace::Handle(	46 const Stacktrace& stacktrace = Stacktrace::Handle(

47 Stacktrace::New(code_array, pc_offset_array));	47 Stacktrace::New(code_array, pc_offset_array));

48 OS::PrintErr("=== Current Trace:\n%s\n===\n", stacktrace.ToCString());	48 OS::PrintErr("=== Current Trace:\n%s===\n", stacktrace.ToCString());
hausner 2015/02/24 22:19:21 Why are you removing the newline after the last st Why are you removing the newline after the last stacktrace line? Does the stacktrace object end with a newline? Ivan Posva 2015/02/24 23:27:18 Yes, ends with a newline and then the output looke Show quoted text On 2015/02/24 22:19:21, hausner wrote: > Why are you removing the newline after the last stacktrace line? Does the > stacktrace object end with a newline? Yes, ends with a newline and then the output looked weird.
49 }	49 }

50	50

51 } // namespace dart	51 } // namespace dart

OLD	NEW