Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 953933002: Improve performance tags display - percent and sorting. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve performance tags display - percent and sorting. R=paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43992

Patch Set 1 #

Total comments: 1

Patch Set 2 : Show two significant figures after the decimal point. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/get_handler.dart View 1 1 chunk +34 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-02-24 17:35:32 UTC) #1
Paul Berry
lgtm once comment is addressed. https://codereview.chromium.org/953933002/diff/1/pkg/analysis_server/lib/src/get_handler.dart File pkg/analysis_server/lib/src/get_handler.dart (right): https://codereview.chromium.org/953933002/diff/1/pkg/analysis_server/lib/src/get_handler.dart#newcode292 pkg/analysis_server/lib/src/get_handler.dart:292: int percent = (tag.elapsedMs ...
5 years, 9 months ago (2015-02-24 17:45:22 UTC) #2
scheglov
5 years, 9 months ago (2015-02-24 17:53:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43992 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698