Improve performance tags display - percent and sorting.

pkg/analysis_server/lib/src/get_handler.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis_server.src.get_handler;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:io';
@@ skipping 249 matching lines @@
     AnalysisServer analysisServer = _server.analysisServer;
     if (analysisServer == null) {
       return _returnFailure(request, 'Analysis server is not running');
     }
     _writeResponse(request, (StringBuffer buffer) {
       _writePage(
           buffer,
           'Analysis Server - Analysis Performance',
           [],
           (StringBuffer buffer) {
-        void writeRow(PerformanceTag tag) {
-          _writeRow(buffer, [tag.elapsedMs, tag.label], classes: ["right", null]);
+
+        buffer.write('<h3>Analysis Performance</h3>');
+
+        {
+          buffer.write('<p><b>Time spent in each phase of analysis</b></p>');
+          buffer.write(
+              '<table style="border-collapse: separate; border-spacing: 10px 5px;">');
+          _writeRow(
+              buffer,
+              ['Time (in ms)', 'Percent', 'Analysis Phase'],
+              header: true);
+          // prepare sorted tags
+          List<PerformanceTag> tags = PerformanceTag.all.toList();
+          tags.remove(ServerPerformanceStatistics.idle);
+          tags.sort((a, b) => b.elapsedMs - a.elapsedMs);
+          // prepare total time
+          int totalTime = 0;
+          tags.forEach((PerformanceTag tag) {
+            totalTime += tag.elapsedMs;
+          });
+          // write rows
+          void writeRow(PerformanceTag tag) {
+            int percent = (tag.elapsedMs * 100) ~/ totalTime;

[Paul Berry, 2015/02/24 17:45:22]

This will round down to percent granularity.  I don't think that's high enough
resolution--sometimes the difference between 1.01% and 1.99% is significant.

How about if we print two significant figures after the decimal point, like
observatory does?

+            _writeRow(
+                buffer,
+                [tag.elapsedMs, '$percent%', tag.label],
+                classes: ["right", "right", null]);
+          }
+          tags.forEach(writeRow);
+          buffer.write('</table>');
         }
 
-        buffer.write('<h3>Analysis Performance</h3>');
-        buffer.write('<p><b>Time spent in each phase of analysis</b></p>');
+        Map<DataDescriptor, Map<CacheState, int>> transitionMap =
+            SourceEntry.transitionMap;
         buffer.write(
-            '<table style="border-collapse: separate; border-spacing: 10px 5px;">');
-        _writeRow(buffer, ['Time (in ms)', 'Analysis Phase'], header: true);
-        PerformanceTag.all.forEach(writeRow);
-        buffer.write('</table>');
-
-        Map<DataDescriptor, Map<CacheState, int>> transitionMap = SourceEntry.transitionMap;
-        buffer.write('<p><b>Number of times a state transitioned to VALID (grouped by descriptor)</b></p>');
+            '<p><b>Number of times a state transitioned to VALID (grouped by descriptor)</b></p>');
         if (transitionMap.isEmpty) {
           buffer.write('<p>none</p>');
         } else {
           List<DataDescriptor> descriptors = transitionMap.keys.toList();
           descriptors.sort(
               (DataDescriptor first, DataDescriptor second) =>
                   first.toString().compareTo(second.toString()));
           for (DataDescriptor key in descriptors) {
             Map<CacheState, int> countMap = transitionMap[key];
             List<CacheState> oldStates = countMap.keys.toList();
@@ skipping 1333 matching lines @@
    * 'error'.
    */
   static String makeLink(String path, Map<String, String> params,
       String innerHtml, [bool hasError = false]) {
     Uri uri = new Uri(path: path, queryParameters: params);
     String href = HTML_ESCAPE.convert(uri.toString());
     String classAttribute = hasError ? ' class="error"' : '';
     return '<a href="$href"$classAttribute>$innerHtml</a>';
   }
 }