Issue 953743005: Fix bug in RangeError.value. Add tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 953743005: Fix bug in RangeError.value. Add tests. (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix bug in RangeError.value. Add tests. BUG= http://dartbug.com/22505 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43990

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -3 lines)			Patch
	M	sdk/lib/core/errors.dart	View		2 chunks	+3 lines, -3 lines	2 comments	Download
	A	tests/corelib/errors_test.dart	View		1 chunk	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Søren Gjesse

lgtm https://codereview.chromium.org/953743005/diff/1/sdk/lib/core/errors.dart File sdk/lib/core/errors.dart (right): https://codereview.chromium.org/953743005/diff/1/sdk/lib/core/errors.dart#newcode125 sdk/lib/core/errors.dart:125: final bool _hasValue; Initialize this to false?

5 years, 10 months ago (2015-02-24 12:09:45 UTC) #3

Lasse Reichstein Nielsen

https://codereview.chromium.org/953743005/diff/1/sdk/lib/core/errors.dart File sdk/lib/core/errors.dart (right): https://codereview.chromium.org/953743005/diff/1/sdk/lib/core/errors.dart#newcode125 sdk/lib/core/errors.dart:125: final bool _hasValue; It's a final variable, I'm sure ...

5 years, 10 months ago (2015-02-24 14:16:23 UTC) #4

Lasse Reichstein Nielsen

5 years, 10 months ago (2015-02-24 14:17:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43990 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages