Fix bug in RangeError.value. Add tests.

sdk/lib/core/errors.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * Error objects thrown in the case of a program failure.
  *
  * An `Error` object represents a program failure that the programmer
@@ skipping 104 matching lines @@
  */
 class NullThrownError extends Error {
   String toString() => "Throw of null.";
 }
 
 /**
  * Error thrown when a function is passed an unacceptable argument.
  */
 class ArgumentError extends Error {
   /** Whether value was provided. */
   final bool _hasValue;

[Søren Gjesse, 2015/02/24 12:09:45]

Initialize this to false?

[Lasse Reichstein Nielsen, 2015/02/24 14:16:22]

It's a final variable, I'm sure it is initialized by all constructors.

   /** The invalid value. */
   final invalidValue;
   /** Name of the invalid argument, if available. */
   final String name;
   /** Message describing the problem. */
   final message;
 
   /**
    * The [message] describes the erroneous argument.
    *
@@ skipping 28 matching lines @@
   /**
    * Create an argument error for a `null` argument that must not be `null`.
    *
    * Shorthand for calling [ArgumentError.value] with a `null` value and a
    * message of `"Must not be null"`.
    */
   ArgumentError.notNull([String name])
       : this.value(null, name, "Must not be null");
 
   // Helper functions for toString overridden in subclasses.
-  String get _errorName => "Invalid argument${name == null ? "(s)" : ""}";
+  String get _errorName => "Invalid argument${!_hasValue ? "(s)" : ""}";
   String get _errorExplanation => "";
 
   String toString() {
     String nameString = "";
     if (name != null) {
       nameString = " ($name)";
     }
-    var message = this.message == null ? "" : ": ${this.message}";
+    var message = (this.message == null) ? "" : ": ${this.message}";
     String prefix = "$_errorName$nameString$message";
-    if (invalidValue == null) return prefix;
+    if (!_hasValue) return prefix;
     // If we know the invalid value, we can try to describe the problem.
     String explanation = _errorExplanation;
     String errorValue = Error.safeToString(invalidValue);
     return "$prefix$explanation: $errorValue";
   }
 }
 
 /**
  * Error thrown due to an index being outside a valid range.
  */
@@ skipping 364 matching lines @@
  * the first time it is read. If evaluating the initializer expression causes
  * another read of the variable, this error is thrown.
  */
 class CyclicInitializationError extends Error {
   final String variableName;
   CyclicInitializationError([this.variableName]);
   String toString() => variableName == null
       ? "Reading static variable during its initialization"
       : "Reading static variable '$variableName' during its initialization";
 }