Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 949283002: Improve displaying overlays. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve displaying overlays. 1. Use path as argument instead of id. 2. Show every file in the global ContentCache just once. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 8 chunks +30 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-24 18:48:23 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-24 19:08:29 UTC) #2
scheglov
5 years, 10 months ago (2015-02-24 19:55:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698