Improve displaying overlays.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:math' show max;
 
@@ skipping 212 matching lines @@
    */
   // Add 1 sec to prevent delay from impacting short running tests
   int _nextPerformOperationDelayTime =
       new DateTime.now().millisecondsSinceEpoch +
       1000;
 
   /**
    * The current state of overlays from the client.  This is used as the
    * content cache for all contexts.
    */
-  ContentCache _overlayState = new ContentCache();
+  final ContentCache overlayState = new ContentCache();
 
   /**
    * Initialize a newly created server to receive requests from and send
    * responses to the given [channel].
    *
    * If [rethrowExceptions] is true, then any exceptions thrown by analysis are
    * propagated up the call stack.  The default is true to allow analysis
    * exceptions to show up in unit tests, but it should be set to false when
    * running a full analysis server.
    */
@@ skipping 728 matching lines @@
   }
 
   /**
    * Implementation for `analysis.updateContent`.
    */
   void updateContent(String id, Map<String, dynamic> changes) {
     changes.forEach((file, change) {
       Source source = getSource(file);
       operationQueue.sourceAboutToChange(source);
       // Prepare the new contents.
-      String oldContents = _overlayState.getContents(source);
+      String oldContents = overlayState.getContents(source);
       String newContents;
       if (change is AddContentOverlay) {
         newContents = change.content;
       } else if (change is ChangeContentOverlay) {
         if (oldContents == null) {
           // The client may only send a ChangeContentOverlay if there is
           // already an existing overlay for the source.
           throw new RequestFailure(
               new Response(
                   id,
@@ skipping 10 matching lines @@
                   error: new RequestError(
                       RequestErrorCode.INVALID_OVERLAY_CHANGE,
                       'Invalid overlay change')));
         }
       } else if (change is RemoveContentOverlay) {
         newContents = null;
       } else {
         // Protocol parsing should have ensured that we never get here.
         throw new AnalysisException('Illegal change type');
       }
-      _overlayState.setContents(source, newContents);
+      overlayState.setContents(source, newContents);
       // Update all contexts.
       for (InternalAnalysisContext context in folderMap.values) {
         if (context.handleContentsChanged(
             source,
             oldContents,
             newContents,
             true)) {
           schedulePerformAnalysisOperation(context);
         } else {
           // When the client sends any change for a source, we should resend
@@ skipping 163 matching lines @@
   /**
    * The stream that is notified when contexts are added or removed.
    */
   Stream<ContextsChangedEvent> get onContextsChanged =>
       _onContextsChangedController.stream;
 
   @override
   AnalysisContext addContext(Folder folder, UriResolver packageUriResolver) {
     InternalAnalysisContext context =
         AnalysisEngine.instance.createAnalysisContext();
-    context.contentCache = analysisServer._overlayState;
+    context.contentCache = analysisServer.overlayState;
     analysisServer.folderMap[folder] = context;
     context.sourceFactory = _createSourceFactory(packageUriResolver);
     context.analysisOptions = new AnalysisOptionsImpl.con1(defaultOptions);
     _onContextsChangedController.add(
         new ContextsChangedEvent(added: [context]));
     analysisServer.schedulePerformAnalysisOperation(context);
     return context;
   }
 
   @override
@@ skipping 145 matching lines @@
    * AnalysisServer.performOperation when the server is idle.
    */
   static PerformanceTag idle = new PerformanceTag('idle');
 
   /**
    * The [PerformanceTag] for time spent in
    * PerformAnalysisOperation._sendNotices.
    */
   static PerformanceTag notices = new PerformanceTag('notices');
 }