Issue 945113002: Add 'Convert Method to Getter' proposal only if it is an available refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 945113002: Add 'Convert Method to Getter' proposal only if it is an available refactoring. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Add 'Convert Method to Getter' proposal only if it is an available refactoring. So, that we don't show it for method with parameter or returning null. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43936

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -81 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickAssistProcessor.java	View	4 chunks	+21 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	3 chunks	+51 lines, -33 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart	View	2 chunks	+23 lines, -23 lines	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	4 chunks	+42 lines, -23 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 10 months ago (2015-02-20 23:18:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43936 (presubmit successful).