Add 'Convert Method to Getter' proposal only if it is an available refactoring.

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library edit.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/collections.dart';
@@ skipping 108 matching lines @@
       CompilationUnit unit = units[0];
       List<Assist> assists = computeAssists(unit, params.offset, params.length);
       assists.forEach((Assist assist) {
         changes.add(assist.change);
       });
     }
     // respond
     return new EditGetAssistsResult(changes).toResponse(request.id);
   }
 
-  Response getAvailableRefactorings(Request request) {
-    if (searchEngine == null) {
-      return new Response.noIndexGenerated(request);
-    }
-    // prepare parameters
-    var params = new EditGetAvailableRefactoringsParams.fromRequest(request);
-    String file = params.file;
-    int offset = params.offset;
-    int length = params.length;
-    // add refactoring kinds
-    List<RefactoringKind> kinds = <RefactoringKind>[];
-    // try EXTRACT_*
-    if (length != 0) {
-      kinds.add(RefactoringKind.EXTRACT_LOCAL_VARIABLE);
-      kinds.add(RefactoringKind.EXTRACT_METHOD);
-    }
-    // try RENAME
-    {
-      List<Element> elements = server.getElementsAtOffset(file, offset);
-      if (elements.isNotEmpty) {
-        Element element = elements[0];
-        RenameRefactoring renameRefactoring =
-            new RenameRefactoring(searchEngine, element);
-        if (renameRefactoring != null) {
-          kinds.add(RefactoringKind.RENAME);
-        }
-      }
-    }
-    // respond
-    return new EditGetAvailableRefactoringsResult(kinds).toResponse(request.id);
-  }
-
   Response getFixes(Request request) {
     var params = new EditGetFixesParams.fromRequest(request);
     String file = params.file;
     int offset = params.offset;
     // add fixes
     List<AnalysisErrorFixes> errorFixesList = <AnalysisErrorFixes>[];
     List<CompilationUnit> units = server.getResolvedCompilationUnits(file);
     for (CompilationUnit unit in units) {
       engine.AnalysisErrorInfo errorInfo = server.getErrors(file);
       if (errorInfo != null) {
@@ skipping 23 matching lines @@
 
   @override
   Response handleRequest(Request request) {
     try {
       String requestName = request.method;
       if (requestName == EDIT_FORMAT) {
         return format(request);
       } else if (requestName == EDIT_GET_ASSISTS) {
         return getAssists(request);
       } else if (requestName == EDIT_GET_AVAILABLE_REFACTORINGS) {
-        return getAvailableRefactorings(request);
+        return _getAvailableRefactorings(request);
       } else if (requestName == EDIT_GET_FIXES) {
         return getFixes(request);
       } else if (requestName == EDIT_GET_REFACTORING) {
         return _getRefactoring(request);
       } else if (requestName == EDIT_SORT_MEMBERS) {
         return sortMembers(request);
       }
     } on RequestFailure catch (exception) {
       return exception.response;
     }
@@ skipping 30 matching lines @@
     }
     // do sort
     int fileStamp = context.getModificationStamp(source);
     String code = context.getContents(source).data;
     MemberSorter sorter = new MemberSorter(code, unit);
     List<SourceEdit> edits = sorter.sort();
     SourceFileEdit fileEdit = new SourceFileEdit(file, fileStamp, edits: edits);
     return new EditSortMembersResult(fileEdit).toResponse(request.id);
   }
 
+  Response _getAvailableRefactorings(Request request) {
+    if (searchEngine == null) {
+      return new Response.noIndexGenerated(request);
+    }
+    _getAvailableRefactoringsImpl(request);
+    return Response.DELAYED_RESPONSE;
+  }
+
+  Future _getAvailableRefactoringsImpl(Request request) async {
+    // prepare parameters
+    var params = new EditGetAvailableRefactoringsParams.fromRequest(request);
+    String file = params.file;
+    int offset = params.offset;
+    int length = params.length;
+    // add refactoring kinds
+    List<RefactoringKind> kinds = <RefactoringKind>[];
+    // try EXTRACT_*
+    if (length != 0) {
+      kinds.add(RefactoringKind.EXTRACT_LOCAL_VARIABLE);
+      kinds.add(RefactoringKind.EXTRACT_METHOD);
+    }
+    // check elements
+    {
+      List<Element> elements = server.getElementsAtOffset(file, offset);
+      if (elements.isNotEmpty) {
+        Element element = elements[0];
+        // try CONVERT_METHOD_TO_GETTER
+        if (element is ExecutableElement) {
+          Refactoring refactoring =
+              new ConvertMethodToGetterRefactoring(searchEngine, element);
+          RefactoringStatus status = await refactoring.checkInitialConditions();
+          if (!status.hasFatalError) {
+            kinds.add(RefactoringKind.CONVERT_METHOD_TO_GETTER);
+          }
+        }
+        // try RENAME
+        {
+          RenameRefactoring renameRefactoring =
+              new RenameRefactoring(searchEngine, element);
+          if (renameRefactoring != null) {
+            kinds.add(RefactoringKind.RENAME);
+          }
+        }
+      }
+    }
+    // respond
+    var result = new EditGetAvailableRefactoringsResult(kinds);
+    server.sendResponse(result.toResponse(request.id));
+  }
+
   Response _getRefactoring(Request request) {
     if (searchEngine == null) {
       return new Response.noIndexGenerated(request);
     }
     if (refactoringManager.hasPendingRequest) {
       refactoringManager.cancel();
       _newRefactoringManager();
     }
     refactoringManager.getRefactoring(request);
     return Response.DELAYED_RESPONSE;
@@ skipping 354 matching lines @@
     }
     if (refactoring is RenameRefactoring) {
       RenameRefactoring renameRefactoring = refactoring;
       RenameOptions renameOptions = params.options;
       renameRefactoring.newName = renameOptions.newName;
       return renameRefactoring.checkNewName();
     }
     return new RefactoringStatus();
   }
 }