Chromium Code Reviews Chromium Code Reviews
Issue
944493002:
Change equality comparison for FileBasedSource to use URI. (Closed)
DescriptionChange equality comparison for FileBasedSource to use URI.
Previously, we considered two FileBasedSources to be equal if they
referred to the same file. As a result, if a given file was
accessible via multiple URI's, only one cache entry would be created
for the file and we would only resolve it once; the elements created
by resolution would be nondeterministic, they would refer to the file
via whatever source happened to be used to analyze it first. Worse
yet, incremental analysis might cause some of the elements in the file
to later be replaced by elements that would refer to the file via a
different source, resulting in confusing errors.
BUG=dartbug.com/22030
R=scheglov@google.com
Committed: https://code.google.com/p/dart/source/detail?r=43888
Patch Set 1 #Patch Set 2 : Reformat and sort code. #
Total comments: 2
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||
