pkg/analyzer/lib/src/generated/source_io.dart - Issue 944493002: Change equality comparison for FileBasedSource to use URI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/source_io.dart

Issue 944493002: Change equality comparison for FileBasedSource to use URI. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Reformat and sort code. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/generated/source_io.dart

diff --git a/pkg/analyzer/lib/src/generated/source_io.dart b/pkg/analyzer/lib/src/generated/source_io.dart

index afc50ff5491a76c002cdb437a4ecc5130e40ac14..d615cf3093dbaa5f8bb9749abaf58c8aa9f2b759 100644

--- a/pkg/analyzer/lib/src/generated/source_io.dart

+++ b/pkg/analyzer/lib/src/generated/source_io.dart

@@ -197,7 +197,7 @@ class FileBasedSource extends Source {

@override

bool operator ==(Object object) =>

- object != null && object is FileBasedSource && file == object.file;

+ object != null && object is FileBasedSource && uri == object.uri;

scheglov 2015/02/19 18:54:47 The check object != null is not necessary, "is" wi

Paul Berry 2015/02/19 19:15:32 Fair enough. Fixed.

@override

bool exists() => file.isFile();

« no previous file with comments | « no previous file | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »