Add ignore-unrecognized-flags as an option to the command line options of analysis server

Add ignore-unrecognized-flags as an option to the command line options of analysis server

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43920

[jwren, 2015-02-19 20:38:10]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[Brian Wilkerson, 2015-02-19 20:44:09]

https://codereview.chromium.org/940093003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/940093003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/server/driver.dart:320: 'ignore-unrecognized-flags',
I thought we were making this the default behavior (that is, that we wouldn't
need a flag).

[Paul Berry, 2015-02-19 21:10:16]

https://codereview.chromium.org/940093003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/940093003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/server/driver.dart:320: 'ignore-unrecognized-flags',
On 2015/02/19 20:44:09, Brian Wilkerson wrote:
> I thought we were making this the default behavior (that is, that we wouldn't
> need a flag).

My recollection matches Brian's.  IIRC, we argued that if we make it an explicit
flag, there is too much danger of a client forgetting to supply it, resulting in
backward compatibility problems.

[jwren, 2015-02-19 21:41:37]

On 2015/02/19 21:10:16, Paul Berry wrote:
>
https://codereview.chromium.org/940093003/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/server/driver.dart (right):
> 
>
https://codereview.chromium.org/940093003/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/server/driver.dart:320:
'ignore-unrecognized-flags',
> On 2015/02/19 20:44:09, Brian Wilkerson wrote:
> > I thought we were making this the default behavior (that is, that we
wouldn't
> > need a flag).
> 
> My recollection matches Brian's.  IIRC, we argued that if we make it an
explicit
> flag, there is too much danger of a client forgetting to supply it, resulting
in
> backward compatibility problems.

PTAL.

Correct.  In implementation I made it consistent with the analyzer.  When
functionality is added to the args.dart library, we'll want this distinction as
well.

[Brian Wilkerson, 2015-02-19 21:58:22]

https://codereview.chromium.org/940093003/diff/20001/pkg/analyzer/lib/options...
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/940093003/diff/20001/pkg/analyzer/lib/options...
pkg/analyzer/lib/options.dart:404:
!args.contains('--ignore-unrecognized-flags')) {
This looks wrong. Previously, we would return immediately if we did *not* want
to ignore unrecognized flags (because the flag was not included). Now we return
immediately if the flag was not included or if we explicitly said we wanted to
ignore unrecognized flags.

Suggests that we need some tests for this new behavior.

The logic would be easier to see if the remainder of this method were inside the
'if'.

[jwren, 2015-02-19 22:55:33]

Take 3, if statement was flipped around which helps.  I was able to get the
--ignore-unknown-flags case tested now, but the alwaysIgnoreUnrecognized is not
tested (couldn't get it tested without making private methods public, which I
stayed away from.)

[Brian Wilkerson, 2015-02-19 23:44:00]

LGTM

[jwren, 2015-02-20 17:20:04]

Committed patchset #3 (id:40001) manually as 43920 (presubmit successful).