dart2js: add function type to the model.

dart2js: add function type to the model.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43911

[zarah, 2015-02-19 15:54:08]

zarah@google.com changed reviewers:
+ floitsch@google.com, herhut@google.com

[floitsch, 2015-02-20 11:00:12]

LGTM.

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:351: final js.Expression
functionType;
Add comment. (when is it null? can it be null?)

While you are at it: the "type" needs documentation too.

What's the difference between the two?

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:507: js.Expression
functionType;
Declare the variable closer to its use.

[zarah, 2015-02-20 12:58:11]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[zarah, 2015-02-20 12:59:32]

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:351: final js.Expression
functionType;
On 2015/02/20 11:00:11, floitsch wrote:
> Add comment. (when is it null? can it be null?)
> 
> While you are at it: the "type" needs documentation too.
> 
> What's the difference between the two?

As far as I can see, we don't use the "type" anymore, so I will remove it.

Added comment.

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/940053002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:507: js.Expression
functionType;
On 2015/02/20 11:00:11, floitsch wrote:
> Declare the variable closer to its use.

Done.

[zarah, 2015-02-20 14:03:58]

Committed patchset #2 (id:20001) manually as 43911 (presubmit successful).