Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938513002: Add ClassMirror.isEnum. (Closed)

Created:
5 years, 10 months ago by rmacnak
Modified:
5 years, 10 months ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ClassMirror.isEnum. BUG=http://dartbug.com/21718 R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=44035

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -8 lines) Patch
M runtime/lib/mirrors.cc View 2 chunks +4 lines, -6 lines 2 comments Download
M runtime/lib/mirrors_impl.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/enum_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 10 months ago (2015-02-18 01:21:02 UTC) #2
gbracha
lgtm
5 years, 10 months ago (2015-02-18 15:47:14 UTC) #3
siva
lgtm https://chromiumcodereview.appspot.com/938513002/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/938513002/diff/1/runtime/lib/mirrors.cc#newcode346 runtime/lib/mirrors.cc:346: args.SetAt(5, Bool::Get(cls.NumTypeParameters() != 0)); How about a method ...
5 years, 10 months ago (2015-02-26 00:07:24 UTC) #4
rmacnak
https://chromiumcodereview.appspot.com/938513002/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://chromiumcodereview.appspot.com/938513002/diff/1/runtime/lib/mirrors.cc#newcode346 runtime/lib/mirrors.cc:346: args.SetAt(5, Bool::Get(cls.NumTypeParameters() != 0)); On 2015/02/26 00:07:24, siva wrote: ...
5 years, 10 months ago (2015-02-26 01:13:16 UTC) #5
rmacnak
5 years, 10 months ago (2015-02-26 01:14:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 44035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698