Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: runtime/lib/mirrors.cc

Issue 938513002: Add ClassMirror.isEnum. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 079a1d03ab7a09f8076a3cff85c5c33214b3c74a..2296a9e6d268e6a626b3be29e4018355717b9c7f 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -330,10 +330,7 @@ static RawInstance* CreateClassMirror(const Class& cls,
UNREACHABLE();
}
- const Bool& is_generic = Bool::Get(cls.NumTypeParameters() != 0);
- const Bool& is_mixin_app_alias = Bool::Get(cls.is_mixin_app_alias());
-
- const Array& args = Array::Handle(Array::New(8));
+ const Array& args = Array::Handle(Array::New(9));
args.SetAt(0, MirrorReference::Handle(MirrorReference::New(cls)));
args.SetAt(1, type);
// Note that the VM does not consider mixin application aliases to be mixin
@@ -346,9 +343,10 @@ static RawInstance* CreateClassMirror(const Class& cls,
}
args.SetAt(3, owner_mirror);
args.SetAt(4, Bool::Get(cls.is_abstract()));
- args.SetAt(5, is_generic);
- args.SetAt(6, is_mixin_app_alias);
+ args.SetAt(5, Bool::Get(cls.NumTypeParameters() != 0));
siva 2015/02/26 00:07:24 How about a method IsGeneric in class Class so tha
rmacnak 2015/02/26 01:13:16 Done.
+ args.SetAt(6, Bool::Get(cls.is_mixin_app_alias()));
args.SetAt(7, cls.NumTypeParameters() == 0 ? Bool::False() : is_declaration);
+ args.SetAt(8, Bool::Get(cls.is_enum_class()));
return CreateMirror(Symbols::_LocalClassMirror(), args);
}
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698