Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 938173004: Small fixes in preparation for SemanticVisitor. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Small fixes in preparation for SemanticVisitor. BUG=http://dartbug.com/20377 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=43912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 6 chunks +11 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 10 months ago (2015-02-20 14:04:21 UTC) #2
karlklose
LGTM.
5 years, 10 months ago (2015-02-20 14:12:22 UTC) #3
Johnni Winther
5 years, 10 months ago (2015-02-20 14:26:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698