Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: tests/compiler/dart2js/analyze_unused_dart2js_test.dart

Issue 938173004: Small fixes in preparation for SemanticVisitor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | tests/compiler/dart2js/type_checker_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyze_unused_dart2js; 5 library analyze_unused_dart2js;
6 6
7 import 'package:async_helper/async_helper.dart'; 7 import 'package:async_helper/async_helper.dart';
8 8
9 import 'package:compiler/src/dart2jslib.dart'; 9 import 'package:compiler/src/dart2jslib.dart';
10 import 'package:compiler/src/filenames.dart'; 10 import 'package:compiler/src/filenames.dart';
11 11
12 import 'analyze_helper.dart'; 12 import 'analyze_helper.dart';
13 13
14 // Do not remove WHITE_LIST even if it's empty. The error message for 14 // Do not remove WHITE_LIST even if it's empty. The error message for
15 // unused members refers to WHITE_LIST by name. 15 // unused members refers to WHITE_LIST by name.
16 const Map<String, List<String>> WHITE_LIST = const { 16 const Map<String, List<String>> WHITE_LIST = const {
17 // Helper methods for debugging should never be called from production code: 17 // Helper methods for debugging should never be called from production code:
18 "lib/src/helpers/": const [" is never "], 18 "lib/src/helpers/": const [" is never "],
19 19
20 // Node.asLiteralBool is never used. 20 // Node.asLiteralBool is never used.
21 "lib/src/tree/nodes.dart": const [ 21 "lib/src/tree/nodes.dart": const [
22 "The method 'asLiteralBool' is never called"], 22 "The method 'asLiteralBool' is never called"],
23 23
24 // Some things in dart_printer are not yet used 24 // Some things in dart_printer are not yet used
25 "lib/src/dart_backend/backend_ast_nodes.dart": const [" is never "], 25 "lib/src/dart_backend/backend_ast_nodes.dart": const [" is never "],
26
27 // MethodElement
28 // TODO(20377): Why is MethodElement unused?
29 "lib/src/elements/elements.dart": const [" is never "]
30 }; 26 };
31 27
32 void main() { 28 void main() {
33 var uri = currentDirectory.resolve( 29 var uri = currentDirectory.resolve(
34 'pkg/compiler/lib/src/use_unused_api.dart'); 30 'pkg/compiler/lib/src/use_unused_api.dart');
35 asyncTest(() => analyze([uri], WHITE_LIST, 31 asyncTest(() => analyze([uri], WHITE_LIST,
36 analyzeAll: false, checkResults: checkResults)); 32 analyzeAll: false, checkResults: checkResults));
37 } 33 }
38 34
39 bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) { 35 bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) {
(...skipping 15 matching lines...) Expand all
55 } else if (member.isTypedef) { 51 } else if (member.isTypedef) {
56 if (member.isResolved) { 52 if (member.isResolved) {
57 compiler.reportHint(member, MessageKind.GENERIC, 53 compiler.reportHint(member, MessageKind.GENERIC,
58 {'text': "Helper typedef in production code '$member'."}); 54 {'text': "Helper typedef in production code '$member'."});
59 } 55 }
60 } 56 }
61 } 57 }
62 compiler.libraryLoader.lookupLibrary(helperUri).forEachLocalMember(checkLive); 58 compiler.libraryLoader.lookupLibrary(helperUri).forEachLocalMember(checkLive);
63 return handler.checkResults(); 59 return handler.checkResults();
64 } 60 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | tests/compiler/dart2js/type_checker_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698