Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 935123002: Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body. R=danrubel@google.com BUG= https://code.google.com/p/dart/issues/detail?id=21879 Committed: https://code.google.com/p/dart/source/detail?r=43857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -86 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 2 chunks +55 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 3 chunks +92 lines, -65 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-18 23:02:09 UTC) #1
danrubel
lgtm
5 years, 10 months ago (2015-02-18 23:03:59 UTC) #2
scheglov
5 years, 10 months ago (2015-02-18 23:17:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698