Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body.

pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.keyword;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 26 matching lines @@
 
   /**
    * The identifier visited or `null` if not visited.
    */
   SimpleIdentifier identifier;
 
   _KeywordVisitor(this.request);
 
   @override
   visitBlock(Block node) {
-    _addSuggestions(
-        [
-            Keyword.ASSERT,
-            Keyword.CASE,
-            Keyword.CONTINUE,
-            Keyword.DO,
-            Keyword.FACTORY,
-            Keyword.FINAL,
-            Keyword.FOR,
-            Keyword.IF,
-            Keyword.NEW,
-            Keyword.RETHROW,
-            Keyword.RETURN,
-            Keyword.SUPER,
-            Keyword.SWITCH,
-            Keyword.THIS,
-            Keyword.THROW,
-            Keyword.TRY,
-            Keyword.VAR,
-            Keyword.VOID,
-            Keyword.WHILE]);
+    if (_isInClassMemberBody(node)) {
+      _addSuggestions(
+          [
+              Keyword.ASSERT,
+              Keyword.CASE,
+              Keyword.CONTINUE,
+              Keyword.DO,
+              Keyword.FINAL,
+              Keyword.FOR,
+              Keyword.IF,
+              Keyword.NEW,
+              Keyword.RETHROW,
+              Keyword.RETURN,
+              Keyword.SUPER,
+              Keyword.SWITCH,
+              Keyword.THIS,
+              Keyword.THROW,
+              Keyword.TRY,
+              Keyword.VAR,
+              Keyword.VOID,
+              Keyword.WHILE]);
+    } else {
+      _addSuggestions(
+          [
+              Keyword.ASSERT,
+              Keyword.CASE,
+              Keyword.CONTINUE,
+              Keyword.DO,
+              Keyword.FINAL,
+              Keyword.FOR,
+              Keyword.IF,
+              Keyword.NEW,
+              Keyword.RETHROW,
+              Keyword.RETURN,
+              Keyword.SWITCH,
+              Keyword.THROW,
+              Keyword.TRY,
+              Keyword.VAR,
+              Keyword.VOID,
+              Keyword.WHILE]);
+    }
   }
 
   @override
   visitClassDeclaration(ClassDeclaration node) {
     // Don't suggest class name
     if (node.name == identifier) {
       return;
     }
     // Inside the class declaration { }
     if (request.offset > node.leftBracket.offset) {
@@ skipping 146 matching lines @@
     if (request.offset == node.end) {
       Token token = node.endToken;
       if (token != null && !token.isSynthetic) {
         if (token.lexeme == ';' || token.lexeme == '}') {
           return true;
         }
       }
     }
     return false;
   }
+
+  static bool _isInClassMemberBody(AstNode node) {
+    while (true) {
+      AstNode body = node.getAncestor((n) => n is FunctionBody);
+      if (body == null) {
+        return false;
+      }
+      AstNode parent = body.parent;
+      if (parent is ConstructorDeclaration || parent is MethodDeclaration) {
+        return true;
+      }
+      node = parent;
+    }
+  }
 }