Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 934413002: Replace the existing unittest APIs with the new runner infrastructure. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace the existing unittest APIs with the new runner infrastructure. This preserves the shape of the previous API, but stubs out the functionality. This is a temporary measure designed to make it easier for users to try the runner out on their existing tests. R=kevmoo@google.com Closes #2 Committed: https://github.com/dart-lang/unittest/commit/0a098e7f895842db421b7fad29eb1de0d1047ee8

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Total comments: 9

Patch Set 3 : Code review changes #

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1382 lines, -4349 lines) Patch
M .status View 1 2 3 1 chunk +1 line, -51 lines 0 comments Download
M CHANGELOG.md View 1 2 3 1 chunk +18 lines, -4 lines 0 comments Download
M lib/compact_vm_config.dart View 1 2 3 1 chunk +9 lines, -203 lines 0 comments Download
M lib/coverage_controller.js View 1 chunk +1 line, -27 lines 0 comments Download
M lib/html_config.dart View 1 2 3 1 chunk +10 lines, -164 lines 0 comments Download
M lib/html_enhanced_config.dart View 1 2 3 1 chunk +10 lines, -394 lines 0 comments Download
M lib/html_individual_config.dart View 1 2 3 1 chunk +9 lines, -42 lines 0 comments Download
M lib/src/configuration.dart View 1 chunk +6 lines, -48 lines 0 comments Download
A + lib/src/expect_async.dart View 9 chunks +60 lines, -29 lines 0 comments Download
D lib/src/expected_function.dart View 1 chunk +0 lines, -203 lines 0 comments Download
M lib/src/future_matchers.dart View 2 chunks +13 lines, -7 lines 0 comments Download
D lib/src/group_context.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D lib/src/internal_test_case.dart View 1 chunk +0 lines, -227 lines 0 comments Download
M lib/src/prints_matcher.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M lib/src/simple_configuration.dart View 1 chunk +5 lines, -108 lines 0 comments Download
M lib/src/test_case.dart View 1 chunk +5 lines, -37 lines 0 comments Download
D lib/src/test_environment.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M lib/src/throws_matcher.dart View 2 chunks +17 lines, -17 lines 0 comments Download
M lib/src/utils.dart View 1 2 chunks +0 lines, -40 lines 0 comments Download
M lib/test_controller.js View 1 chunk +1 line, -229 lines 0 comments Download
M lib/unittest.dart View 1 2 2 chunks +99 lines, -391 lines 0 comments Download
M lib/vm_config.dart View 1 2 3 1 chunk +10 lines, -49 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +1 line, -5 lines 0 comments Download
D test/async_exception_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D test/async_exception_with_future_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D test/async_setup_teardown_test.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D test/breath_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D test/completion_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M test/console_reporter_test.dart View 1 6 chunks +23 lines, -24 lines 0 comments Download
D test/correct_callback_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D test/exception_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D test/excess_callback_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D test/expect_async_args_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M test/expect_async_test.dart View 1 chunk +288 lines, -60 lines 0 comments Download
D test/future_matchers_test.dart View 1 chunk +0 lines, -98 lines 0 comments Download
D test/group_name_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D test/invalid_ops_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
M test/io.dart View 1 2 3 1 chunk +12 lines, -4 lines 0 comments Download
D test/late_exception_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
M test/loader_test.dart View 1 2 chunks +3 lines, -6 lines 0 comments Download
A test/matcher/completion_test.dart View 1 chunk +100 lines, -0 lines 0 comments Download
A test/matcher/prints_test.dart View 1 chunk +149 lines, -0 lines 0 comments Download
A test/matcher/throws_test.dart View 1 chunk +149 lines, -0 lines 0 comments Download
A test/matcher/throws_type_test.dart View 1 chunk +178 lines, -0 lines 0 comments Download
D test/matchers_minified_test.dart View 1 chunk +0 lines, -139 lines 0 comments Download
D test/matchers_unminified_test.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D test/middle_exception_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D test/missing_tick_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D test/nested_groups_setup_teardown_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D test/prints_matcher_test.dart View 1 chunk +0 lines, -144 lines 0 comments Download
D test/protect_async_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D test/returning_future_test.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D test/returning_future_using_runasync_test.dart View 1 chunk +0 lines, -87 lines 0 comments Download
M test/runner_test.dart View 1 4 chunks +25 lines, -4 lines 0 comments Download
D test/runtests_without_tests_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D test/setup_and_teardown_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D test/setup_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D test/single_correct_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D test/single_failing_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D test/skipped_soloed_nested_test.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D test/teardown_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D test/test_utils.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D test/testcases_immutable_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D test/throws_matchers_test.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M test/utils.dart View 1 3 chunks +159 lines, -10 lines 0 comments Download
M test/vm_listener_test.dart View 1 6 chunks +9 lines, -13 lines 0 comments Download
D test/with_test_environment_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
nweiz
5 years, 10 months ago (2015-02-19 02:21:34 UTC) #1
kevmoo
Some initial thoughts, pre rebase https://codereview.chromium.org/934413002/diff/1/lib/unittest.dart File lib/unittest.dart (right): https://codereview.chromium.org/934413002/diff/1/lib/unittest.dart#newcode19 lib/unittest.dart:19: hide You should be ...
5 years, 10 months ago (2015-02-19 15:24:43 UTC) #2
nweiz
Code review changes
5 years, 10 months ago (2015-02-19 21:02:18 UTC) #3
nweiz
https://codereview.chromium.org/934413002/diff/1/lib/unittest.dart File lib/unittest.dart (right): https://codereview.chromium.org/934413002/diff/1/lib/unittest.dart#newcode19 lib/unittest.dart:19: hide On 2015/02/19 15:24:43, kevmoo wrote: > You should ...
5 years, 10 months ago (2015-02-19 21:02:23 UTC) #4
kevmoo
lgtm https://codereview.chromium.org/934413002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/934413002/diff/20001/CHANGELOG.md#newcode5 CHANGELOG.md:5: end in `_test.dart` and aren't in a `packages/` ...
5 years, 10 months ago (2015-02-19 23:13:19 UTC) #5
nweiz
Code review changes
5 years, 10 months ago (2015-02-19 23:43:37 UTC) #7
nweiz
5 years, 10 months ago (2015-02-19 23:44:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0a098e7f895842db421b7fad29eb1de0d1047ee8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698