Generate artificial hashCode for often used classes.

Generate artificial hashCode for often used classes.

By avoiding calling Object.hashCode we analyze about 1% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43832

[Paul Berry, 2015-02-17 23:26:50]

lgtm

[Brian Wilkerson, 2015-02-18 01:07:50]

LGTM

[scheglov, 2015-02-18 01:12:53]

Committed patchset #1 (id:1) manually as 43832 (presubmit successful).

[kasperl, 2015-02-18 08:04:16]

kasperl@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2015-02-18 08:04:16]

https://codereview.chromium.org/934113002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/index/index.dart (right):

https://codereview.chromium.org/934113002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/index/index.dart:330: final int _hashCode =
_NEXT_HASH_CODE++;
Have you considered masking here? If you start overflowing the smi limit, you
might get considerably worse performance.

[scheglov, 2015-02-18 17:20:32]

https://codereview.chromium.org/934113002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/index/index.dart (right):

https://codereview.chromium.org/934113002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/index/index.dart:330: final int _hashCode =
_NEXT_HASH_CODE++;
On 2015/02/18 08:04:16, kasperl wrote:
> Have you considered masking here? If you start overflowing the smi limit, you
> might get considerably worse performance.

Good question.
See https://codereview.chromium.org/936823002