Issue 936823002: Mask ResolvableLibrary hashCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 936823002: Mask ResolvableLibrary hashCode. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Mask ResolvableLibrary hashCode. We create these objects often, so in theory we may overflowing the smi limit. I wonder if extracting a mixin would be as effective and help to share code. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43852

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

LGTM > I wonder if extracting a mixin would be as effective and help to ...

5 years, 10 months ago (2015-02-18 17:41:23 UTC) #2

scheglov

5 years, 10 months ago (2015-02-18 19:43:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43852 (presubmit successful).