Issue 932983002: To satisfy ASAN, use stub instead of & operator to get C++ stack pointer.

Issue 932983002: To satisfy ASAN, use stub instead of & operator to get C++ stack pointer. (Closed)

Created:
5 years, 10 months ago by koda

Modified:
5 years, 10 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

To satisfy ASAN, use stub instead of & operator to get C++ stack pointer. Because of initialization order, this requires slightly different paths for VM isolate and others. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43865

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -22 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	1 2 3 4 5 6 7 8	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/dart_entry.cc	View	1 2 3 4 5 6 7 8	2 chunks	+5 lines, -6 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 2 3 4 5 6 7 8	3 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3 4 5 6 7 8	3 chunks	+32 lines, -6 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 2 3 4 5 6 7 8	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2 3 4 5 6 7 8	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1 2 3 4 5 6 7 8	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

koda

On 2015/02/18 22:50:25, zra wrote: > Does this change have any effects on performance? Although ...

5 years, 10 months ago (2015-02-19 00:24:36 UTC) #4

koda

5 years, 10 months ago (2015-02-19 04:58:17 UTC) #7

Message was sent while issue was closed.

Committed patchset #9 (id:160001) manually as r43865 (presubmit successful).