runtime/vm/simulator_arm.cc - Issue 932983002: To satisfy ASAN, use stub instead of & operator to get C++ stack pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_arm.cc

Issue 932983002: To satisfy ASAN, use stub instead of & operator to get C++ stack pointer. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/simulator_arm.cc

===================================================================

--- runtime/vm/simulator_arm.cc (revision 43859)

+++ runtime/vm/simulator_arm.cc (working copy)

@@ -56,7 +56,7 @@

link_ = sim->last_setjmp_buffer();

sim->set_last_setjmp_buffer(this);

sp_ = static_cast<uword>(sim->get_register(SP));

- native_sp_ = reinterpret_cast<uword>(&sim); // Current C++ stack pointer.

+ native_sp_ = Isolate::GetCurrentStackPointer();

}

~SimulatorSetjmpBuffer() {

@@ -1524,7 +1524,7 @@

(redirection->call_kind() == kBootstrapNativeCall) ||

(redirection->call_kind() == kNativeCall)) {

// Set the top_exit_frame_info of this simulator to the native stack.

- set_top_exit_frame_info(reinterpret_cast<uword>(&buffer));

+ set_top_exit_frame_info(Isolate::GetCurrentStackPointer());

}

if (redirection->call_kind() == kRuntimeCall) {

NativeArguments arguments;

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »