Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 932523004: Fix Function.apply for static functions in new emitter. (Closed)

Created:
5 years, 10 months ago by herhut
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Function.apply for static functions in new emitter. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43910

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 5 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
herhut
5 years, 10 months ago (2015-02-19 09:57:35 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/932523004/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/932523004/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode131 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:131: 'argCnt': js.string(namer.requiredParameterField), use non-abbreviated names. (I guess the ...
5 years, 10 months ago (2015-02-20 09:07:01 UTC) #2
herhut
https://codereview.chromium.org/932523004/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/932523004/diff/1/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode131 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:131: 'argCnt': js.string(namer.requiredParameterField), On 2015/02/20 09:07:01, floitsch wrote: > use ...
5 years, 10 months ago (2015-02-20 12:24:15 UTC) #4
herhut
5 years, 10 months ago (2015-02-20 12:47:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698