Fix Function.apply for static functions in new emitter.

pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.model_emitter;
 
 import '../../constants/values.dart' show ConstantValue;
 import '../../dart2jslib.dart' show Compiler;
 import '../../dart_types.dart' show DartType;
 import '../../elements/elements.dart' show ClassElement;
@@ skipping 110 matching lines @@
 
        'cyclicThrow':
            backend.emitter.staticFunctionAccess(backend.getCyclicThrowHelper()),
        'outputContainsConstantList': program.outputContainsConstantList,
        'embeddedGlobals': emitEmbeddedGlobals(program),
        'constants': emitConstants(fragment.constants),
        'staticNonFinals':
             emitStaticNonFinalFields(fragment.staticNonFinalFields),
        'operatorIsPrefix': js.string(namer.operatorIsPrefix),
        'callName': js.string(namer.callNameField),
+       'argCnt': js.string(namer.requiredParameterField),

[floitsch, 2015/02/20 09:07:01]

use non-abbreviated names.

(I guess the same applies for the non-static stubs).

[herhut, 2015/02/20 12:24:15]

Done.

+       'defArgValues': js.string(namer.defaultValuesField),
        'eagerClasses': emitEagerClassInitializations(fragment.libraries),
        'invokeMain': fragment.invokeMain,
        'code': code};
 
     holes.addAll(nativeHoles(program));
 
     return js.js.statement(boilerplate, holes);
   }
 
   Map<String, dynamic> nativeHoles(Program program) {
@@ skipping 683 matching lines @@
       };
     } else {
       // Parse the tear off information and generate compile handlers.
       // TODO(herhut): Share parser with instance methods.      
       function compileAllStubs() {
         var funs;
         var fun = compile(name, descriptor[0]);
         fun[#callName] = descriptor[1];
         holder[name] = fun;
         funs = [fun];
-        for (var pos = 4; pos < descriptor.length; pos += 3) {
+        // We iterate in blocks of 3 but have to stop before we reach the
+        // (optional) two trailing items. To accomplish this, we only iterate
+        // until we reach length - 2.
+        for (var pos = 4; pos < descriptor.length - 2; pos += 3) {
           var stubName = descriptor[pos];
           fun = compile(stubName, descriptor[pos + 2]);
           fun[#callName] = descriptor[pos + 1];
           holder[stubName] = fun;
           funs.push(fun);
         }
         if (descriptor[2] != null) {  // tear-off name.
           // functions, reflectionInfo, isStatic, name, isIntercepted.
           holder[descriptor[2]] = 
               tearOff(funs, descriptor[3], true, name, false);
         }
+        if (descriptor[pos] != null) {

[floitsch, 2015/02/20 09:07:01]

if (pos < descriptor.length) ?

[herhut, 2015/02/20 12:24:15]

Why not :-)

+          fun[#argCnt] = descriptor[pos];
+          fun[#defArgValues] = descriptor[pos + 1];
+        }
       }
 
       function setupCompileAllAndDelegateStub(name) {
         holder[name] = function() {
           compileAllStubs();
           return holder[name].apply(this, arguments);
         };
       }
 
       setupCompileAllAndDelegateStub(name);
@@ skipping 168 matching lines @@
 
   var end = Date.now();
   // print('Setup: ' + (end - start) + ' ms.');
 
   #invokeMain;  // Start main.
 
 }(Date.now(), #code)
 }""";
 
 }