Make pkg/stack_trace use stack chains.

Make pkg/stack_trace use stack chains.

scheduled_test now uses stack chains for all of its error reporting. This also
adds a number of [Chain.track] calls to work around issue 15105.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30836

[Bob Nystrom, 2013-12-03 22:24:46]

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
pkg/scheduled_test/lib/src/schedule.dart:505: var stackString =
prefixLines(terseTraceString(chain));
Should this be "terseChainString" now?

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
pkg/scheduled_test/lib/src/utils.dart:35: Future syncFuture(callback()) =>
Chain.track(new Future.sync(callback));
Why is this needed? Does this not go through the zone stuff?

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
pkg/scheduled_test/lib/src/utils.dart:237: frame.package == 'stack_trace' ||
frame.isCore;
How do you feel about wrapping each to its own line and lining them up?

return frame.package == 'scheduled_test' ||
       frame.package == 'unittest' ||
       frame.package == 'stack_trace' ||
       frame.isCore;

[nweiz, 2013-12-03 22:34:31]

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
pkg/scheduled_test/lib/src/schedule.dart:505: var stackString =
prefixLines(terseTraceString(chain));
On 2013/12/03 22:24:47, Bob Nystrom wrote:
> Should this be "terseChainString" now?

It still takes a StackTrace; it will just play nicely with stack chains as well.

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
File pkg/scheduled_test/lib/src/utils.dart (right):

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
pkg/scheduled_test/lib/src/utils.dart:35: Future syncFuture(callback()) =>
Chain.track(new Future.sync(callback));
On 2013/12/03 22:24:47, Bob Nystrom wrote:
> Why is this needed? Does this not go through the zone stuff?

No; Future.sync has its own try/catch that applies within the callback that's
passed to the zone specification. Issue 15105 is tracking this.

https://codereview.chromium.org/93143002/diff/40001/pkg/scheduled_test/lib/sr...
pkg/scheduled_test/lib/src/utils.dart:237: frame.package == 'stack_trace' ||
frame.isCore;
On 2013/12/03 22:24:47, Bob Nystrom wrote:
> How do you feel about wrapping each to its own line and lining them up?
> 
> return frame.package == 'scheduled_test' ||
>        frame.package == 'unittest' ||
>        frame.package == 'stack_trace' ||
>        frame.isCore;

Done.

[Bob Nystrom, 2013-12-03 23:07:24]

lgtm

[nweiz, 2013-12-04 00:19:02]

Committed patchset #4 manually as r30836 (presubmit successful).