Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: pkg/scheduled_test/lib/src/scheduled_server/handler.dart

Issue 93143002: Make pkg/stack_trace use stack chains. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/src/scheduled_future_matchers.dart ('k') | pkg/scheduled_test/lib/src/task.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/src/scheduled_server/handler.dart
diff --git a/pkg/scheduled_test/lib/src/scheduled_server/handler.dart b/pkg/scheduled_test/lib/src/scheduled_server/handler.dart
index 316d53611a6be91549f7241537a59c06f1d64645..ecac381ee7eaa9ab194f862c81d9afd57498fca6 100644
--- a/pkg/scheduled_test/lib/src/scheduled_server/handler.dart
+++ b/pkg/scheduled_test/lib/src/scheduled_server/handler.dart
@@ -53,7 +53,7 @@ class Handler {
// between a test failing while waiting for a handler and a test failing
// while executing a handler.
chainToCompleter(schedule(() {
- return new Future.sync(() {
+ return syncFuture(() {
if (request.method != method || request.uri.path != path) {
fail("'${server.description}' expected $method $path, "
"but got ${request.method} ${request.uri.path}.");
@@ -71,7 +71,7 @@ class Handler {
/// completing. Otherwise, completes immediately.
Future _waitForTask() {
return pumpEventQueue().then((_) {
- if (currentSchedule.currentTask != _taskBefore) return;
+ if (currentSchedule.currentTask != _taskBefore) return null;
// If we're one task before the handler was scheduled, wait for that
// task to complete and pump the event queue so that [ready] will be
// set.
« no previous file with comments | « pkg/scheduled_test/lib/src/scheduled_future_matchers.dart ('k') | pkg/scheduled_test/lib/src/task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698