Constant top-level variables should not have setters.

Constant top-level variables should not have setters.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43793

[Brian Wilkerson, 2015-02-15 22:49:43]

LGTM

https://codereview.chromium.org/930703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/930703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element_resolver.dart:2511: }
I don't really understand why it was necessary to change the order of lookup,
given that getters and method cannot have the same name. Not that there's
anything wrong with this order either, but...

[scheglov, 2015-02-16 05:35:54]

https://codereview.chromium.org/930703002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/930703002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element_resolver.dart:2511: }
On 2015/02/15 22:49:43, Brian Wilkerson wrote:
> I don't really understand why it was necessary to change the order of lookup,
> given that getters and method cannot have the same name. Not that there's
> anything wrong with this order either, but...

It corresponds to _resolveProperty() now.

[scheglov, 2015-02-16 05:36:21]

Committed patchset #1 (id:1) manually as 43793 (presubmit successful).