pkg/analyzer/lib/src/generated/resolver.dart - Issue 930703002: Constant top-level variables should not have setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 930703002: Constant top-level variables should not have setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer/lib/src/generated/element_resolver.dart ('K') | « pkg/analyzer/lib/src/generated/element_resolver.dart ('k') | pkg/analyzer/test/generated/all_the_rest_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 70a80bfb0674246533603108496ebd815dc24efe..209e9fdcbe94b9439c7efc6883e6844201609d10 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -3192,7 +3192,7 @@ class ElementBuilder extends RecursiveAstVisitor<Object> {

getter.getter = true;

_currentHolder.addAccessor(getter);

variable.getter = getter;

- if (!isFinal) {

+ if (!isConst && !isFinal) {

PropertyAccessorElementImpl setter =

new PropertyAccessorElementImpl.forVariable(variable);

setter.setter = true;