Implement Function.apply in the new emitter.

Implement Function.apply in the new emitter.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43807

[herhut, 2015-02-16 14:18:54]

herhut@google.com changed reviewers:
+ floitsch@google.com, zarah@google.com

[floitsch, 2015-02-16 15:26:03]

LGTM.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:365: this.canBeReflected,
this.requiredParameterCount,
indent one more.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:559: ///
[InstanceMethod.aliasName] (optional).
Since this is dartdoc, writing the fields line per line doesn't work.
I guess the easiest is to make it a bulleted list.

ditto for the other two lists.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:569: ///
[ParameterStubMethod.code]
Something seems to be missing here.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:571: /// for each
stub in [DartMethod.parameterStubs]. If [DartMethod.canBeApplied]
Start a new paragraph.

If the closure could be used in `Function.apply` ([DartMethod.canBeApplied] is
true) then the following fields are appended:

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:604: for (++pos;
pos < descriptor.length - 2; pos += 3) {
add a comment why the "2".

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:606:
stub.$callName = descriptor[pos + 1];
This should be a shared variable. (the "$callName").

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1051:
JS_GET_NAME("REQUIRED_PARAMETER_PROPERTY"));
In another CL: JS_GET_NAME should use embedded_names.dart.

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1061: var jsFunction = JS('',
'#["call*"]', interceptor);
"call*" should be shared name.

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1090: var value =
namedArguments[key];
indendation.

[herhut, 2015-02-17 10:24:58]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[herhut, 2015-02-17 10:25:40]

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/model.dart:365: this.canBeReflected,
this.requiredParameterCount,
On 2015/02/16 15:26:03, floitsch wrote:
> indent one more.

Done.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:559: ///
[InstanceMethod.aliasName] (optional).
On 2015/02/16 15:26:03, floitsch wrote:
> Since this is dartdoc, writing the fields line per line doesn't work.
> I guess the easiest is to make it a bulleted list.
> 
> ditto for the other two lists.

Done.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:569: ///
[ParameterStubMethod.code]
On 2015/02/16 15:26:03, floitsch wrote:
> Something seems to be missing here.

[ParameterStubMethod.callName] was missing. Fixed.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:571: /// for each
stub in [DartMethod.parameterStubs]. If [DartMethod.canBeApplied]
On 2015/02/16 15:26:03, floitsch wrote:
> Start a new paragraph.
> 
> If the closure could be used in `Function.apply` ([DartMethod.canBeApplied] is
> true) then the following fields are appended:

Done.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:604: for (++pos;
pos < descriptor.length - 2; pos += 3) {
On 2015/02/16 15:26:03, floitsch wrote:
> add a comment why the "2".

Done.

https://codereview.chromium.org/928203003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:606:
stub.$callName = descriptor[pos + 1];
On 2015/02/16 15:26:03, floitsch wrote:
> This should be a shared variable. (the "$callName").

Done.

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1051:
JS_GET_NAME("REQUIRED_PARAMETER_PROPERTY"));
On 2015/02/16 15:26:03, floitsch wrote:
> In another CL: JS_GET_NAME should use embedded_names.dart.

Acknowledged.

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1061: var jsFunction = JS('',
'#["call*"]', interceptor);
On 2015/02/16 15:26:03, floitsch wrote:
> "call*" should be shared name.

Done.

https://codereview.chromium.org/928203003/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1090: var value =
namedArguments[key];
On 2015/02/16 15:26:03, floitsch wrote:
> indendation.

Done.

[herhut, 2015-02-17 11:48:00]

Committed patchset #3 (id:40001) manually as 43807 (presubmit successful).