Implement Function.apply in the new emitter.

sdk/lib/_internal/compiler/js_lib/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_js_embedded_names' show
     GET_TYPE_FROM_NAME,
     GET_ISOLATE_TAG,
     INTERCEPTED_NAMES,
@@ skipping 1025 matching lines @@
 
     return function.noSuchMethod(
         createUnmangledInvocationMirror(
             #call,
             selectorName,
             JSInvocationMirror.METHOD,
             arguments,
             namedArgumentList));
   }
 
+  static applyFunctionNewEmitter(Function function,
+                                 List positionalArguments,
+                                 Map<String, dynamic> namedArguments) {
+    if (namedArguments == null) {
+      int requiredParameterCount = JS('int', r'#[#]', function,
+          JS_GET_NAME("REQUIRED_PARAMETER_PROPERTY"));

[floitsch, 2015/02/16 15:26:03]

In another CL: JS_GET_NAME should use embedded_names.dart.

[herhut, 2015/02/17 10:25:39]

Acknowledged.

+      int argumentCount = positionalArguments.length;
+      if (argumentCount < requiredParameterCount) {
+        return functionNoSuchMethod(function, positionalArguments, null);
+      }
+      String selectorName = '${JS_GET_NAME("CALL_PREFIX")}\$$argumentCount';
+      var jsStub = JS('var', r'#[#]', function, selectorName);
+      if (jsStub == null) {
+        // Do a dynamic call.
+        var interceptor = getInterceptor(function);
+        var jsFunction = JS('', '#["call*"]', interceptor);

[floitsch, 2015/02/16 15:26:03]

"call*" should be shared name.

[herhut, 2015/02/17 10:25:39]

Done.

+        var defaultValues = JS('var', r'#[#]', function,
+            JS_GET_NAME("DEFAULT_VALUES_PROPERTY"));
+        if (!JS('bool', '# instanceof Array', defaultValues)) {
+          // The function expects named arguments!
+          return functionNoSuchMethod(function, positionalArguments, null);
+        }
+        int defaultsLength = JS('int', "#.length", defaultValues);
+        int maxArguments = requiredParameterCount + defaultsLength;
+        if (argumentCount > maxArguments) {
+          // The function expects less arguments!
+          return functionNoSuchMethod(function, positionalArguments, null);
+        }
+        List arguments = new List.from(positionalArguments);
+        List missingDefaults = JS('JSArray', '#.slice(#)', defaultValues,
+            argumentCount - requiredParameterCount);
+        arguments.addAll(missingDefaults);
+        return JS('var', '#.apply(#, #)', jsFunction, function, arguments);
+      }
+      return JS('var', '#.apply(#, #)', jsStub, function, positionalArguments);
+    } else {
+      var interceptor = getInterceptor(function);
+      var jsFunction = JS('', '#["call*"]', interceptor);
+      var defaultValues = JS('JSArray', r'#[#]', function,
+          JS_GET_NAME("DEFAULT_VALUES_PROPERTY"));
+      List keys = JS('JSArray', r'Object.keys(#)', defaultValues);
+      List arguments = new List.from(positionalArguments);
+      int used = 0;
+      for (String key in keys) {
+         var value = namedArguments[key];

[floitsch, 2015/02/16 15:26:03]

indendation.

[herhut, 2015/02/17 10:25:39]

Done.

+        if (value != null) {
+          used++;
+          arguments.add(value);
+        } else {
+          arguments.add(JS('var', r'#[#]', defaultValues, key));
+        }
+      }
+      if (used != namedArguments.length) {
+        return functionNoSuchMethod(function, positionalArguments,
+            namedArguments);
+      }
+      return JS('var', r'#.apply(#, #)', jsFunction, function, arguments);
+    }
+  }
+
   static applyFunction(Function function,
                        List positionalArguments,
                        Map<String, dynamic> namedArguments) {
     // Dispatch on presence of named arguments to improve tree-shaking.
     //
     // This dispatch is as simple as possible to help the compiler detect the
     // common case of `null` namedArguments, either via inlining or
     // specialization.
     return namedArguments == null
         ? applyFunctionWithPositionalArguments(
@@ skipping 1030 matching lines @@
     for (int i = 1; i < functions.length; i++) {
       var stub = functions[i];
       var stubCallName = JS('String|Null', '#.\$callName', stub);
       if (stubCallName != null) {
         JS('', '#[#] = #', prototype, stubCallName,
            isStatic ? stub : forwardCallTo(receiver, stub, isIntercepted));
       }
     }
 
     JS('', '#["call*"] = #', prototype, trampoline);
+    String reqArgProperty = JS_GET_NAME("REQUIRED_PARAMETER_PROPERTY");
+    String defValProperty = JS_GET_NAME("DEFAULT_VALUES_PROPERTY");
+    JS('', '#.# = #.#', prototype, reqArgProperty, function, reqArgProperty);
+    JS('', '#.# = #.#', prototype, defValProperty, function, defValProperty);
 
     return constructor;
   }
 
   static cspForwardCall(int arity, bool isSuperCall, String stubName,
                         function) {
     var getSelf = RAW_DART_FUNCTION_REF(BoundClosure.selfOf);
     // Handle intercepted stub-names with the default slow case.
     if (isSuperCall) arity = -1;
     switch (arity) {
@@ skipping 1614 matching lines @@
   // This is a function that will return a helper function that does the
   // iteration of the sync*.
   //
   // Each invocation should give a helper with fresh state.
   final dynamic /* js function */ _outerHelper;
 
   SyncStarIterable(this._outerHelper);
 
   Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
 }