Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 924783005: Improve code generation for 'bottom' and 'dynamic' arguments. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve code generation for 'bottom' and 'dynamic' arguments. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 10 months ago (2015-02-13 20:50:06 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-13 20:52:45 UTC) #2
scheglov
5 years, 10 months ago (2015-02-13 21:02:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698