pkg/analysis_server/lib/src/services/correction/util.dart - Issue 924783005: Improve code generation for 'bottom' and 'dynamic' arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/util.dart

Issue 924783005: Improve code generation for 'bottom' and 'dynamic' arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | pkg/analysis_server/test/services/correction/fix_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/correction/util.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/util.dart b/pkg/analysis_server/lib/src/services/correction/util.dart

index 837afd85b65f5a8466b7e8299d91fa1a522a0403..2400e3f32c56680262a90a1ae831811a300906ab 100644

--- a/pkg/analysis_server/lib/src/services/correction/util.dart

+++ b/pkg/analysis_server/lib/src/services/correction/util.dart

@@ -934,6 +934,7 @@ class CorrectionUtils {

/**

* Returns the source to reference [type] in this [CompilationUnit].

+ * May return `null` if [type] does not have a source.

* Fills [librariesToImport] with [LibraryElement]s whose elements are

* used by the generated source, but not imported.

@@ -944,6 +945,10 @@ class CorrectionUtils {

if (type is FunctionType && type.element is! FunctionTypeAliasElement) {

return "Function";

}

+ // dynamic or BottomType

+ if (type.isDynamic || type.isBottom) {

+ return null;

+ }

// prepare element

Element element = type.element;

if (element == null) {